skip document during indexing if error occurs #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an error is returned by search3-java, we handle it by throwing a generic bad_request exception. This is the error handling path for both search and indexing requests. During indexing however, the exception is not caught and it leads to a search_worker_manager process crash. The process is restarted by the search3_sup supervisor and the indexing begins again. This leads to an endless loop of trying to index the same document if the documents causes some sort of error. We modify this behavior by catching the thrown exception and ignoring the document.
tonysun83
changed the title
rnewson
reviewed
Nov 4, 2019
| @@ -131,6 +132,12 @@ handle_response({ok, #{session := Session} = Response, _}, | |||
| handle_response({error, Error}, _) -> | |||
| handle_error_response({error, Error}). | |||
|
|
|||
| handle_update_response({ok, #{session := Session}, _}, CurrentSession) -> | |||
| VSession = verify_same_session(CurrentSession, Session), | |||
| VSession; | |||
There was a problem hiding this comment.
this doesn't look like the right result. handle_response returns {VSession, Response} above, for example.
There was a problem hiding this comment.
@rnewson handle_response was a generic handler and Response was need for other rpc requests. However in the case of updates, Response isn't needed, so I removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an error is returned by search3-java, we handle it by throwing a
generic bad_request exception. This is the error handling path for both
search and indexing requests. During indexing however, the exception is
not caught and it leads to a search_worker_manager process crash. The
process is restarted by the search3_sup supervisor and the indexing
begins again. This leads to an endless loop of trying to index the same
document if the documents causes some sort of error. We modify this
behavior by catching the thrown exception and ignoring the document.